Bugzilla – Bug 11455
[Clamav-devel] Patch to force freshclam download progress meter
Last modified: 2016-02-19 11:31:29 EST
Created attachment 7018 [details] patch file From Mark Allan: Hi all, With the release of 0.99, I got caught out by a change to freshclam's output. The end result is the same (defs do/don't get updated) so none of my automated tests caught it, but when you actually sit and watch the output, I'm not getting the download progress meter in my GUI any more. The change that tripped it up was commit #cf5ba11 - Avoid emitting incremental progress messages when not outputting to a terminal. I've included a patch which works against 0.99 stable as well as current HEAD (#1f85811) to add a new command line flag --show-progress to freshclam to force the output of the progress meter if freshclam isn't being called via a terminal. Hopefully the additional flag won't cause problems for anyone, so it would be really great if the patch could be included please. Many thanks, Mark
I see this patch didn't make it into 0.99.1-beta. Not a huge deal as I can always patch locally before distributing my build, but it would be great if I didn't have to. I'm wondering if there's anything I can do to help it get accepted? Are there any changes I need to make to the patch which would help? Thanks Mark
Thanks, we'll check it out and try to get it into 0.99.1.
Reviewed, tested, and added for inclusion in 0.99.1. https://github.com/vrtadmin/clamav-devel/commit/2eeea01b863ffd03b49f2a8d0ec6d1320a7f5d9a